Use proper formatter placeholder for strings

[dluksza]

Java's String.format uses %s for string placeholders. %d is used for decimal numbers. This fixes IllegalFormatConversionException.

Fixes: #97

[cbrevik]

Thank you for this PR @dluksza! I'll merge and release a patch-version.

It's kind of interesting if you get this log-statement actually, because it shouldn't happen. Would be interesting to find out cases it does log.

[cbrevik]

Published as 2.6.1

[dluksza]

It's kind of interesting if you get this log-statement actually, because it shouldn't happen. Would be interesting to find out cases it does log.

I've only got it once on production so can't test it. My app is selling since mid of October and did over 50 in app purchases successfully. Only this one time this error happen.

BTW. How about adding callbacks so that those error can be handled on the JS side eg. be logged to firebase/crashlytics/mixpanel etc. this way we could get more information wether everything works as expected. Right now those error will be lost on production and nobody will know that they occurred.

[cbrevik]

Well that'd be nice I suppose, but what exactly should we call back to? The problem here is that the callbacks themselves does not exist in the cache. :)

I guess one way to do it would be to fire an event.

[dluksza]

I was thinking about a callback within else branch, before or after Log.w() statement, so that we can track how often this happen on production. Right now all warnings (on production) are lost, since they are not propagated to $external_logging_system.

Of course the best would be to not have else branch at all and always succeed, but I assume that this not so obvious to achieve.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.