Skip to content

Vast Terminology Overhaul#16

Merged
henkbirkholz merged 19 commits intomainfrom
core-terms
Mar 9, 2023
Merged

Vast Terminology Overhaul#16
henkbirkholz merged 19 commits intomainfrom
core-terms

Conversation

@henkbirkholz
Copy link
Copy Markdown
Member

Fixes #15

(to some extend), please see #15 and check the issues highlighted there as part of reviewing this PR.

Signed-off-by: Henk Birkholz <henk.birkholz@sit.fraunhofer.de>
yogeshbdeshpande and others added 2 commits February 22, 2023 18:36
Co-authored-by: Maik Riechert <maik.riechert@microsoft.com>
Signed-off-by: Yogesh Deshpande <yogesh.deshpande@arm.com>
@yogeshbdeshpande
Copy link
Copy Markdown
Collaborator

@henkbirkholz @fournet @letmaik
All claim terminology has been replaced with "Signed Statement" including the Architecture Diagram.

Please have a look!

Signed-off-by: Henk Birkholz <henk.birkholz@sit.fraunhofer.de>
…t-architecture into core-terms

Signed-off-by: Henk Birkholz <henk.birkholz@sit.fraunhofer.de>
…1114212028

Signed-off-by: Henk Birkholz <henk.birkholz@sit.fraunhofer.de>
Copy link
Copy Markdown
Collaborator

@SteveLasker SteveLasker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 to simplify a "claim" becomes "statement" and refer to statements that change "state" (#8)
Statement --> Signed Statment --> Transparent Statement

Copy link
Copy Markdown
Collaborator

@nedmsmith nedmsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Multiple comments

Signed-off-by: Henk Birkholz <henk.birkholz@sit.fraunhofer.de>
Signed-off-by: Henk Birkholz <henk.birkholz@sit.fraunhofer.de>
Signed-off-by: Henk Birkholz <henk.birkholz@sit.fraunhofer.de>
@SteveLasker
Copy link
Copy Markdown
Collaborator

Thank you @nedmsmith, @nealmcb, @OR13, @yogeshbdeshpande, @fournet, @letmaik, @kaywilliams, @raylutz and a very speshal thanks to @henkbirkholz for all feedback and suggestions.
As noted above, we needed to get this overhaul merged for smaller PRs, to meet the IETF 116 Monday milestone

If we've missed anything, please open an issue for discussion, or if it's easy, a small PR may be more efficient.

@nealmcb
Copy link
Copy Markdown

nealmcb commented Mar 10, 2023

Great work @SteveLasker! Above-and-beyond the call, to take so many of our frequently-off-topic responses and capture them in new issues.

@SteveLasker
Copy link
Copy Markdown
Collaborator

Thanks @nealmcb, and thank you for all the great feedback. Unfortunately, I didn't see GitHub was nice enough to "hide" many of the outstanding items, so I guess there's more to capture... 🤷‍♂️

SteveLasker added a commit to SteveLasker/draft-ietf-scitt-architecture that referenced this pull request Oct 3, 2023
@SteveLasker SteveLasker deleted the core-terms branch October 23, 2023 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Global Terminology Overhaul & Some Text Issues

9 participants