Move "Tips & More Info" link from homepage to top menu bar#83
Closed
Iniquit wants to merge 1 commit into
Closed
Conversation
Iniquit
changed the title
Iniquit
force-pushed
the
tips-in-menubar
branch
2 times, most recently
from
5c63e55 to
e50c70c
Compare
Iniquit
force-pushed
the
tips-in-menubar
branch
from
e50c70c to
99c24d2
Compare
dfabulich
reviewed
Mar 20, 2021
| recommendation engine. IFDB is a Wiki-style | ||
| community project: members can add new game listings, write | ||
| reviews, exchange game recommendations, and more. | ||
| <span class=details><a href="tips">Tips & More Info</a></span> |
Collaborator
There was a problem hiding this comment.
I wonder if we should add this back? It's OK to have multiple links, especially if our goal is to make that page more visible.
Collaborator
|
This commit is currently in conflict with the main branch and with your responsive home page branch! 😬 We may want to let the responsive home page branch go through first, and then reapply this PR again later when the header is refactored and the code is settled down…? |
Contributor
Author
|
Sounds like a good idea! This one is super small anyway. |
Collaborator
|
I'm going to close this old conflicting PR. Feel free to reopen in the future. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! It's exciting to see IFDB go open source! This PR addresses ifdb-suggestion-tracker issue iftechfoundation/ifdb#763. Also standardizes spaces between "curarrow" icon and the menu items next to it (made them all use a single space, like 'Home' uses now.)
Before:
After:
