Skip to content

Brand customization#297

Merged
james9909 merged 1 commit into
illinois:masterfrom
ubccpsctech:brand-customization
Feb 20, 2020
Merged

Brand customization#297
james9909 merged 1 commit into
illinois:masterfrom
ubccpsctech:brand-customization

Conversation

@winstan

@winstan winstan commented Nov 13, 2019

Copy link
Copy Markdown
Contributor

This provides a mechanism to configure Queue for a different institution via the environment variables INSTITUTION_LABEL and NETID_LABEL.

@vercel

vercel Bot commented Nov 13, 2019

Copy link
Copy Markdown

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/illinois/queue/jjolyxgwxu
✅ Preview: In Progress

@nwalters512

Copy link
Copy Markdown
Contributor

This was implemented in more depth in #288 - would you like to assist with reviewing that PR? cc @james9909 - can you give more context on #283? It looks like that was merged, but I can't find any commits for it on master.

@james9909

Copy link
Copy Markdown
Member

@nwalters512: the content in #288 is the same as #283. We reverted master and re-opened the PR because when the deploy broke, we still wanted others to develop and merge onto a working master until Wade got a chance to redeploy.

@nwalters512

Copy link
Copy Markdown
Contributor

@james9909 gotcha - is there any more work needed before it can be merged again? Would you be able to champion that branch and see it through to being merged?

@james9909

Copy link
Copy Markdown
Member

@nwalters512 - we're waiting for when @wadefagen's ableto set up a clone of the queue on prod. Since I tested everything out on staging without issues, it should be fine but we want to test it out before merging.
Don't worry, I'm still pushing to get it merged :)

@winstan

winstan commented Nov 14, 2019

Copy link
Copy Markdown
Contributor Author

@nwalters512: #288 is missing the institution name customization in this PR, as well as the use of environment variables for customization.
I'm happy to help... Maybe I could help #288 through and then update this PR to just add institutionName to publicRuntimeConfig in next.config.js?
(Cinda is eager to get Queue working at UBC as soon as possible...)

@vercel vercel Bot temporarily deployed to staging November 14, 2019 17:27 Inactive
@winstan

winstan commented Nov 14, 2019

Copy link
Copy Markdown
Contributor Author

There, in lieu of #288, I've ripped out the NetID changes from this PR.
Now this PR just parameterizes institution name, and does it using publicRuntimeConfig like in #288.

@winstan

winstan commented Feb 20, 2020

Copy link
Copy Markdown
Contributor Author

Now that #288 is merged, I've rebased this. It's all ready to go...

@james9909 james9909 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@james9909 james9909 merged commit 5949be8 into illinois:master Feb 20, 2020
@winstan winstan deleted the brand-customization branch February 20, 2020 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants