Question about GradCache support (#198)

[whybe-choi]

Hi @ManuelFay,

I'm interested in the GradCache support proposed in PR #198.

Is this feature still planned for the official roadmap? If not, I'd like to continue the implementation and submit a new PR.
I’d be happy to contribute to the project if you are open to it.

Looking forward to your reply!

Best regards,
Yongbin Choi

[whybe-choi]

Hi, @ManuelFay !
could you please take a look at this issue when you have a chance?

[ManuelFay]

Hey ! I don't think I'll continue. The reason was that it worked very well when I made the PR but didn't yield performance improvements, offline hard negative mining was more efficient. Having said that, if you wanna update the PR please feel free to do so.
A few tips:

• I'll probably only merge in main if: either it gets perf improvements, or the code is very self contained and doesn't add too much bloat. It might be worth it not to just add a "gradcache flag" but really construct a class (WithGradCache) to really control the induced bloating.
• other than that, I believe it should be fairly easy to rebase my branch.

Goof luck