Skip to content

Fix for maven warnings#2157

Merged
iluwatar merged 2 commits into
iluwatar:masterfrom
mohanaraosv:fix-maven-warnings
Oct 30, 2022
Merged

Fix for maven warnings#2157
iluwatar merged 2 commits into
iluwatar:masterfrom
mohanaraosv:fix-maven-warnings

Conversation

@mohanaraosv
Copy link
Copy Markdown
Contributor

Resolve maven warning

image

Pull request description

  • Removed duplicated dependency declaration
  • Updated junit-jupiter-api junit dependency co-ordinates

For detailed contributing instructions see https://github.com/iluwatar/java-design-patterns/wiki/01.-How-to-contribute

Comment thread page-object/pom.xml Outdated
@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

80.0% 80.0% Coverage
0.0% 0.0% Duplication

@iluwatar iluwatar self-assigned this Oct 30, 2022
@iluwatar iluwatar added this to the 1.26.0 milestone Oct 30, 2022
@iluwatar iluwatar merged commit adb0e25 into iluwatar:master Oct 30, 2022
@iluwatar
Copy link
Copy Markdown
Owner

Thanks for chasing out these warnings!

@all-contributors please add @mohanaraosv for code

@allcontributors
Copy link
Copy Markdown
Contributor

@iluwatar

I couldn't determine any contributions to add, did you specify any contributions?
Please make sure to use valid contribution names.

@mohanaraosv already contributed before to code

@iluwatar
Copy link
Copy Markdown
Owner

@all-contributors please add @robertvolkmann for review

@allcontributors
Copy link
Copy Markdown
Contributor

@iluwatar

I've put up a pull request to add @robertvolkmann! 🎉

@mohanaraosv mohanaraosv deleted the fix-maven-warnings branch November 1, 2022 00:10
robertvolkmann pushed a commit to robertvolkmann/java-design-patterns that referenced this pull request Nov 6, 2022
* fix for maven warnings

* Removed unwanted dependency and htmlunit upgraded to latest

Co-authored-by: Mohana Rao S V <mohana.rao.s.v@tietoevry.com>
robertvolkmann added a commit to robertvolkmann/java-design-patterns that referenced this pull request Nov 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants