Fix sonar issues#2925

Merged

iluwatar merged 21 commits into

iluwatar:masterfrom

k1w1dev:fix/sonar-issues

May 4, 2024

Commits on May 3, 2024

Remove unused member which was also causing a false positive sonar issue.
k1w1dev
committed
Fixes sonar issue https://sonarcloud.io/project/issues?open=AXK0OzDA-CiGJS70dLki&id=iluwatar_java-design-patterns
k1w1dev
committed
checkstyle fix
k1w1dev
committed
Add sneaky throws to fix sonar lint issue. This is fine as the newFile method is not being tested but instead the new SimpleFileWriter(...) is.
k1w1dev
committed
The first booking needs to happen outside the assertions. Fixed other warnings
k1w1dev
committed
Use records to pass around related objects instead of using a large number of
k1w1dev
committed
Checkstyle fixes
k1w1dev
committed
checkstyle fixes
k1w1dev
committed
Remove complexity to keep sonar happy.
k1w1dev
committed
Split into different methods to reduce complexity. Could be broken down even further but currently Sonar is happy.
k1w1dev
committed
Move files to correct package
k1w1dev
committed
Add valid assertions to tests
k1w1dev
committed
rename constants to avoid confusion
k1w1dev
committed
Sonar warning related to cognitive complexity can be suppressed as the methods are quite generic and not functional enough to be separated out.
k1w1dev
committed
Use constants to keep Sonar happy
k1w1dev
committed
Use correct constant naming conventions
k1w1dev
committed
Use correct constant naming conventions
k1w1dev
committed
Use lombok to define noargsconstructor
k1w1dev
committed
Use a single method to do the logging
k1w1dev
committed
Remove unused constructor and redundant method
k1w1dev
committed
Use a reusable method for logging
k1w1dev
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix sonar issues#2925

Fix sonar issues#2925
iluwatar merged 21 commits into
iluwatar:masterfrom
k1w1dev:fix/sonar-issues

Commits on May 3, 2024

Remove unused member which was also causing a false positive sonar issue.

Fixes sonar issue https://sonarcloud.io/project/issues?open=AXK0OzDA-CiGJS70dLki&id=iluwatar_java-design-patterns

checkstyle fix

Add sneaky throws to fix sonar lint issue. This is fine as the newFile method is not being tested but instead the new SimpleFileWriter(...) is.

The first booking needs to happen outside the assertions. Fixed other warnings

Use records to pass around related objects instead of using a large number of

Checkstyle fixes

checkstyle fixes

Remove complexity to keep sonar happy.

Split into different methods to reduce complexity. Could be broken down even further but currently Sonar is happy.

Move files to correct package

Add valid assertions to tests

rename constants to avoid confusion

Sonar warning related to cognitive complexity can be suppressed as the methods are quite generic and not functional enough to be separated out.

Use constants to keep Sonar happy

Use correct constant naming conventions

Use correct constant naming conventions

Use lombok to define noargsconstructor

Use a single method to do the logging

Remove unused constructor and redundant method

Use a reusable method for logging