fix: resolve SonarCloud issue in App.java #2865

[2897robo]

What does this PR do?

This PR resolves a high severity issue (java:S2095) reported by SonarCloud in App.java.
The issue was that ScheduledExecutorService was not properly closed, potentially leading to resource leakage.

🔗 SonarCloud issue: https://sonarcloud.io/project/issues?id=iluwatar_java-design-patterns&open=AZXOQp-k7L73unJ7u3kj

What did I do?

• Wrapped ScheduledExecutorService with try-finally to ensure proper shutdown
• Added a Thread.sleep(45000) for demonstration purposes to allow task completion before shutdown
• Confirmed locally with IntelliJ SonarLint (project bound to SonarCloud) that the warning is resolved
• Verified successful analysis from SonarCloud (Quality Gate Passed)

References

• Bound IntelliJ SonarLint to SonarCloud (see project wiki's IDE instructions)
• Rule: java:S2095

Fixes #2865

[github-actions]

PR Summary

This PR resolves a SonarCloud issue in App.java by adding a try-finally block to ensure the ScheduledExecutorService is properly shut down, preventing resource leaks. A 45-second delay is added for demonstration purposes before the executor service is shut down.

Changes

File	Summary
dirty-flag/src/main/java/com/iluwatar/dirtyflag/App.java	The ScheduledExecutorService is now wrapped in a try-finally block to guarantee proper shutdown. A Thread.sleep(45000) is added for demonstration, allowing tasks to complete before shutdown. Error handling is improved with logging of interruptions.

---

autogenerated by presubmit.ai

[github-actions]

✅ LGTM!

Review Summary

Commits Considered (1)

• 7ebf744: fix: resolve SonarCloud issue in App.java #2865

Files Processed (1)

• dirty-flag/src/main/java/com/iluwatar/dirtyflag/App.java (1 hunk)

Actionable Comments (0)

Skipped Comments (1)

• dirty-flag/src/main/java/com/iluwatar/dirtyflag/App.java [76-77]

  enhancement: "Remove sleep for production."

[2897robo]

Hi @iluwatar,
This PR fixes a high severity issue reported by SonarCloud. I verified the fix locally using SonarLint bound to SonarCloud.
Kindly review when you get a chance 😊

[github-actions]

✅ LGTM!

Review Summary

Commits Considered (1)

• a8bffc1: Merge branch 'master' into fix/sonar-high-issue-dirty-flag-app

Files Processed (0)

Actionable Comments (0)

Skipped Comments (0)

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
50.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[iluwatar]

Looks good! Thank you for the contribution 🎉

@all-contributors please add @2897robo for code

[allcontributors]

@iluwatar

I've put up a pull request to add @2897robo! 🎉