[feat] 콜렉션 생성 부분 이미지 처리 #195
Merged
Merged
Conversation
1 task
soeun11
requested review from
H0sungKim and
rosejinse
and removed request for
H0sungKim
H0sungKim
approved these changes
Jun 16, 2026
H0sungKim
left a comment
H0sungKim
left a comment
Contributor
There was a problem hiding this comment.
코멘트 체크 한번 해주세요!!
고생하셨습니다~~!!
Comment on lines
+59
to
+64
| // MARK: - UseCase | ||
|
|
||
| lazy var uploadCollectionImageUseCase: UploadCollectionImageUseCase = DefaultUploadCollectionImageUseCase( | ||
| storageRepository: makeStorageRepository() | ||
| ) | ||
|
|
Comment on lines
+49
to
59
| // MARK: - Init | ||
| public init( | ||
| viewModel: CreateCollectionViewModel, | ||
| uploadImageUseCase: UploadCollectionImageUseCase, | ||
| viewControllerFactory: ViewControllerFactory? = nil | ||
| ) { | ||
| self.viewModel = viewModel | ||
| self.uploadImageUseCase = uploadImageUseCase | ||
| super.init(nibName: nil, bundle: nil) | ||
| self.viewControllerFactory = viewControllerFactory | ||
| } |
Contributor
There was a problem hiding this comment.
viewcontroller 가 usecase 직접 들고있는 이유가 있나요???
이왕이면 viewmodel 이 usecase들고있고 viewcontroller 가 viewmodel통해서 호출하는게 나을 것 같아서요
rosejinse
approved these changes
Jun 19, 2026
rosejinse
left a comment
rosejinse
left a comment
Member
There was a problem hiding this comment.
이미지 처리 잘 해주신 것 같아욥!! 저작권 안내도 깔꼼하네요
컬렉션 생성할 때 문제 없는지만 보면 되겟군요잉
고생하셧습니다 !!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Related Issues
📋 Description
📱 Screenshot
💬 To Reviewers
이미지 잘 한거 맞나요 ?