Skip to content

Conversation

@alextran1502
Copy link
Member

@alextran1502 alextran1502 commented Dec 16, 2025

  • Show date and time information in the top app bar
  • Move the motion button down below the app bar
image

@meesfrensel
Copy link
Collaborator

How is the behavior in landscape mode? The date and time are in that overlay bar so that seems fine, but you wouldn't want that motion photo button in the middle of the image, right?

@alextran1502
Copy link
Member Author

How is the behavior in landscape mode? The date and time are in that overlay bar so that seems fine, but you wouldn't want that motion photo button in the middle of the image, right?

I am debating about the position of the motion button. I don't like it very much in the middle of the viewer as well

@alextran1502 alextran1502 force-pushed the better-info-in-asset-viewer branch from 0d13c97 to 0e8b927 Compare December 17, 2025 15:58
@idubnori
Copy link
Collaborator

idubnori commented Dec 17, 2025

@shenlong-tanwen
Copy link
Member

How is the behavior in landscape mode? The date and time are in that overlay bar so that seems fine, but you wouldn't want that motion photo button in the middle of the image, right?

It doesn't look bad in the landscape mode. So we could use the same design in both orientations. Or, if this looks distracting, we can move it back to the app bar (i.e, the overlay bar) in landscape mode

iPad - Landscape

image

Pixel - Landscape

image |

final originalTheme = context.themeData;

final actions = <Widget>[
if (asset.isMotionPhoto) const MotionPhotoActionButton(iconOnly: true),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not used elsewhere. If we are not going to keep this button in the app bar on landscape orientation, the file can now be safely removed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants