Skip to content

Conversation

@idubnori
Copy link
Collaborator

@idubnori idubnori commented Dec 17, 2025

Description

This PR consolidates the outcome of the discussion so far and applies the agreed changes to the bottom action buttons.

  • Reflect the current consensus on which actions should be visible per context
  • Keep the scope limited to button composition

Button changes by context

Context Current buttom buttons After this change Unit tests
Asset (local only) share, upload, edit share, upload, edit, delete
Shared album share, edit, addto, delete share, addto, open activity, like
Locked folder (none) share, unlock, delete
  • Minor adjustments
    • No visual or behavioral change other than text wrapping support

How has this been tested?

  • Unit tests added for the updated button lists and regressions
  • Visual regression checks across the affected contexts

Screenshots (if appropriate)

screen-recording-immich-18.mp4

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if applicable
  • I have no unrelated changes in the PR.
  • I have confirmed that any new dependencies are strictly necessary.
  • I have written tests for new code (if applicable)
  • I have followed naming conventions/patterns in the surrounding code
  • All code in src/services/ uses repositories implementations for database calls, filesystem operations, etc.
  • All code in src/repositories/ is pretty basic/simple and does not have any immich specific logic (that belongs in src/services/)

Please describe to which degree, if any, an LLM was used in creating this pull request.

  • initial impl / refactoring / test code

@idubnori idubnori marked this pull request as ready for review December 17, 2025 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants