fix(cli): allow easily crawling paths with parentheses #24670
+15
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meesfrensel
force-pushed
the
fix/crawl-parentheses
branch
from
11341d7 to
26ffd43
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Escape parentheses in glob paths.
This might technically be a regression for users that use the
(a|b)regex/glob syntax. I didn't see any explicit note of that anywhere in the cli docs, and folder/album names with years are a reasonably common use case I'd say.If not desired I'll open another PR specifying what to expect from the globbed inputs and how to crawl folders with e.g. parentheses.
Fixes #23885
How Has This Been Tested?
Added a unit test for the crawl.