transpile: Do not leak main argument strings#1447
Merged
Merged
Conversation
Rua
force-pushed
the
main-leak
branch
4 times, most recently
from
e10b712 to
2f26db6
Compare
kkysen
reviewed
Nov 10, 2025
kkysen
left a comment
kkysen
left a comment
Contributor
There was a problem hiding this comment.
Can you add a snapshot test for this, too?
Rua
force-pushed
the
main-leak
branch
2 times, most recently
from
326ac44 to
ba0f652
Compare
kkysen
reviewed
Nov 12, 2025
kkysen
left a comment
kkysen
left a comment
Contributor
There was a problem hiding this comment.
Sorry, can you also do the thing where the snapshot test is added first before the fix, then updated along with the fix? Thanks!
kkysen
suggested changes
Nov 16, 2025
kkysen
approved these changes
Dec 7, 2025
kkysen
left a comment
kkysen
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Sorry it took me a while to get back around to this. Just a couple minor comment things I think would be helpful.
| vec![mk().method_call_expr( | ||
| mk().method_call_expr( | ||
| mk().call_expr( | ||
| // TODO(kkysen) change `"std"` to `"alloc"` after `#![feature(alloc_c_string)]` is stabilized in `1.63.0` |
Contributor
There was a problem hiding this comment.
Actually, I think we can switch to it now. rust-lang/rust#99277 was merged on 2022-07-16, before 2022-08-08.
Contributor
Author
There was a problem hiding this comment.
Changing std to alloc doesn't seem to work:
failed to resolve: use of unresolved module or unlinked crate
alloc
I guess that it's not as simple as just swapping out one for the other.
Contributor
There was a problem hiding this comment.
Ah, I think we also need to add extern crate alloc;. We can do that separately then, and just leave the comment here for now.
kkysen
approved these changes
Dec 7, 2025
kkysen
added a commit
that referenced
this pull request
Dec 7, 2025
…` generated is detected as a test When testing `main.c`, `main.rs` is generated, and `cargo` thinks `c2rust-transpile/tests/snapshots/main.rs` is a second `snapshots` test, in addition to `c2rust-transpile/tests/snapshots.rs`: ```shell ❯ cargo test -p c2rust-transpile error: failed to load manifest for workspace member `/home/kkysen/work/c2rust/c2rust` Caused by: failed to load manifest for dependency `c2rust-transpile` Caused by: failed to parse manifest at `/home/kkysen/work/c2rust/c2rust-transpile/Cargo.toml` Caused by: found duplicate test name snapshots, but all test targets must have a unique name ``` This was from #1447, but wasn't caught in CI because it only runs `cargo test` a single time.
kkysen
added a commit
that referenced
this pull request
Dec 8, 2025
…generated is detected as a test When testing `main.c`, `main.rs` is generated, and `cargo` thinks `c2rust-transpile/tests/snapshots/main.rs` is a second `snapshots` test, in addition to `c2rust-transpile/tests/snapshots.rs`: ```shell ❯ cargo test -p c2rust-transpile error: failed to load manifest for workspace member `/home/kkysen/work/c2rust/c2rust` Caused by: failed to load manifest for dependency `c2rust-transpile` Caused by: failed to parse manifest at `/home/kkysen/work/c2rust/c2rust-transpile/Cargo.toml` Caused by: found duplicate test name snapshots, but all test targets must have a unique name ``` This was from #1447, but wasn't caught in CI because it only runs `cargo test` a single time.
kkysen
added a commit
that referenced
this pull request
Dec 8, 2025
…generated is detected as a test (#1499) When testing `main.c`, `main.rs` is generated, and `cargo` thinks `c2rust-transpile/tests/snapshots/main.rs` is a second `snapshots` test, in addition to `c2rust-transpile/tests/snapshots.rs`: ```shell ❯ cargo test -p c2rust-transpile error: failed to load manifest for workspace member `/home/kkysen/work/c2rust/c2rust` Caused by: failed to load manifest for dependency `c2rust-transpile` Caused by: failed to parse manifest at `/home/kkysen/work/c2rust/c2rust-transpile/Cargo.toml` Caused by: found duplicate test name snapshots, but all test targets must have a unique name ``` This was from #1447, but wasn't caught in CI because it only runs `cargo test` a single time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mainleaks memory ofargs#649.I opted to store the final strings as
Vec<u8>rather than asCString, because the latter does not have a way to get a mutable pointer/reference without leaking it. This is because of the nul termination invariant thatCStringmust uphold.