This repository was archived by the owner on Jul 18, 2025. It is now read-only.
restores "recordExecutionTime" compatibility with vanilla statsd #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelsembwever
referenced
this pull request
Mar 28, 2014
- Add support for initialization-time constant tag list (similar use case to constant prefix). - Convert millisecond times to floating-point histogram type for compatibility with upstream semantics.
|
The whitespace changes seems to have cause some kind of problem with merging the commit. |
Author
|
sorry about that. i've been trying to avoid creating whitespace changes. but it happens all too easily. it's possible to view the diff on github by adding "?w=1" to the url, |
Author
|
rebased off 5d34. since 73b4c5b on master does not compile. |
references: statsd documentation – https://github.com/etsy/statsd/blob/master/docs/metric_types.md breakage from commit dcae – indeedeng@dcaed45#commitcomment-5832637
|
Tested with dd-agent 3.10.0 looks like a compatible change. |
camerondavison
added a commit
that referenced
this pull request
Apr 30, 2014
restores "recordExecutionTime" compatibility with vanilla statsd
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
references: