Add fillShadowGradientTo option#513
Merged
Merged
Conversation
|
How we can help to move this PR forward? |
|
Any chance this can be merged? |
Contributor
Author
|
Bump |
|
Why hasn't this been merged? |
Contributor
Author
|
it's coming up on a year since this PR was submitted back in May of 2021... I believe perhaps this project has been abandoned unfortunately. @Devorein @Hermanya @noktigula @sreuter anyone have any further information for us? |
Contributor
|
Thank you for your contribution 👍 this is now available in v6.12.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In an effort to allow for a linear gradient shadow fill that blends one color into another, this PR replaces
fillShadowGradientandfillShadowGradientOpacitywith new "To" and "From" options:fillShadowGradientFromfillShadowGradientFromOpacityfillShadowGradientTofillShadowGradientToOpacityIn the
AbstractChartcomponent, iffillShadowGradientTois provided in the chart config, then it's used for the second<Stop>SVG element, otherwisefillShadowGradientFromis used. Similarly, iffillShadowGradientToOpacityis provided, then that's used for the second<Stop>SVG element's opacity, otherwise a default value of 0 is used.Lastly, it maintains backwards compatibility with the current
fillShadowGradientandfillShadowGradientOpacityoptions.