Add Euler 1 dim step option to shortcuts.py#277
Draft
aakashnarayan wants to merge 1 commit into
Draft
Conversation
Owner
|
Thanks! Could you look into the linter failure? Also, this is missing documentation and tests. When writing the documentation, it might be good to remind the user that the stability region for forward Euler includes no nonzero part of the imaginary axis, and therefore forward Euler is unstable for DG operators applied to hyperbolic PDEs discretized with central fluxes. |
Owner
|
Please add a test and fix the linter. Converting to draft and unsubcribing in the meantime, please request review when ready. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.