Skip to content

Use comm.scatter for mesh distribution#308

Merged
inducer merged 1 commit into
mainfrom
mesh-dist-scatter
May 3, 2023
Merged

Use comm.scatter for mesh distribution#308
inducer merged 1 commit into
mainfrom
mesh-dist-scatter

Conversation

@inducer

@inducer inducer commented May 3, 2023

Copy link
Copy Markdown
Owner

@inducer inducer requested a review from majosm May 3, 2023 17:24
@majosm

majosm commented May 3, 2023

Copy link
Copy Markdown
Collaborator

Hmm, I think the mirgecom tests are failing because the wall coupling was merged (and therefore mirgecom now depends on my #285 branch). I'm going to check if there's an easy way to make those changes conditional so the CI still works here in the meantime.

@inducer

inducer commented May 3, 2023

Copy link
Copy Markdown
Owner Author

No need IMO, as long as #285 goes in soon. I can just ignore the mirgecom failures for the time being. But I've put the downstream issue on the agenda for Friday, too, to at least have a discussion.

@majosm majosm left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@inducer inducer merged commit 7380319 into main May 3, 2023
@inducer inducer deleted the mesh-dist-scatter branch May 3, 2023 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants