No more string tags#245
Merged
Merged
Conversation
kaushikcfd
reviewed
Mar 8, 2021
kaushikcfd
requested changes
Mar 8, 2021
kaushikcfd
left a comment
kaushikcfd
left a comment
Collaborator
There was a problem hiding this comment.
Thanks. I like the example use-case through UseStreamingStore tag.
…ad (bump pytools req for that)
inducer
changed the title
kaushikcfd
approved these changes
Mar 12, 2021
kaushikcfd
left a comment
kaushikcfd
left a comment
Collaborator
There was a problem hiding this comment.
One minor concern, otherwise LGTM. Thanks!
Collaborator
|
Good to go from my end. |
Owner
Author
|
Thanks for taking a look, and sorry about the nag! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TaggedVariableandInstructionBaseshould inherit fromTaggable.