Misc. distributed fixes/tweaks#208
Merged
Merged
Conversation
doesn't currently check for InterPartitionAdjacencyGroup
alexfikl
reviewed
Jun 3, 2021
alexfikl
left a comment
alexfikl
left a comment
Collaborator
There was a problem hiding this comment.
Left a few nitpicks, hope that's ok!
Co-authored-by: Alex Fikl <alexfikl@gmail.com>
Owner
|
Unsubscribing... @-mention or request review once it's ready for a look or needs attention. |
Collaborator
Author
|
I think this one is ready for a look @inducer. |
inducer
approved these changes
Jun 3, 2021
inducer
left a comment
inducer
left a comment
Owner
There was a problem hiding this comment.
Thanks! I'll apply the one suggestion.
Owner
? |
Collaborator
Author
See comment above. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pulled out of #204 to declutter.