Skip to content

Broadcast binary ops with device scalars#502

Merged
inducer merged 7 commits into
inducer:mainfrom
kaushikcfd:partial_broadcasting
Jul 6, 2021
Merged

Broadcast binary ops with device scalars#502
inducer merged 7 commits into
inducer:mainfrom
kaushikcfd:partial_broadcasting

Conversation

@kaushikcfd

Copy link
Copy Markdown
Contributor

@inducer inducer left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just a few minor things below, then this is ready to go in.

Comment thread pyopencl/array.py Outdated
Comment thread pyopencl/array.py Outdated
Comment thread pyopencl/array.py Outdated
Comment thread pyopencl/array.py Outdated
Comment thread pyopencl/array.py Outdated
Comment thread pyopencl/array.py Outdated
Comment thread pyopencl/array.py
kaushikcfd and others added 2 commits July 5, 2021 14:46
op -> operator

Co-authored-by: Andreas Klöckner <inform@tiker.net>
@inducer

inducer commented Jul 5, 2021

Copy link
Copy Markdown
Owner

Unsubscribing... @-mention or request review once it's ready for a look or needs attention.

@kaushikcfd kaushikcfd requested a review from inducer July 6, 2021 00:57
@inducer inducer enabled auto-merge (squash) July 6, 2021 05:12
@inducer

inducer commented Jul 6, 2021

Copy link
Copy Markdown
Owner

Thanks!

@inducer

inducer commented Jul 6, 2021

Copy link
Copy Markdown
Owner

We probably want a release with that. I'll do that tomorrow, assuming this merges OK.

@inducer inducer merged commit f4b73fc into inducer:main Jul 6, 2021
@inducer

inducer commented Jul 7, 2021

Copy link
Copy Markdown
Owner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Broadcasting with device scalars?

2 participants