Use a better rscale from Greengard 1988#115
Merged
Merged
Conversation
3 tasks
1 task
Collaborator
Author
|
@inducer, this is ready. |
inducer
approved these changes
May 6, 2022
inducer
left a comment
inducer
left a comment
Owner
There was a problem hiding this comment.
Thanks! LGTM, just a bit of merge logistics to sort out.
| run: | | ||
| curl -L -O https://tiker.net/ci-support-v0 | ||
| . ./ci-support-v0 | ||
| if [[ "$DOWNSTREAM_PROJECT" == "pytential" ]]; then |
Owner
There was a problem hiding this comment.
Could you add a conditional that makes this turn itself off on main? Since this and the pytential PR are mutually dependent, the process I like is the following:
- merge sumpy
- observe broken (downstream) CI on sumpy
main - drop branch spec on pytential
- merge pytential
- rerun previously broken sumpy
mainCI, observe fixed
Owner
|
Thanks! In it goes. |
Owner
|
That is: I'm OK with merging this and pytential#150 using the procedure above. Could you take care of that? |
Collaborator
Author
|
Sure. I'll do the merging with the given steps. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needed for #113 to get one of the tests to pass with FFT.