Misc modernize (pyupgrade)#99
Merged
Merged
Conversation
Owner
Collaborator
Author
Collaborator
|
Thanks. Let's wait until we get #95 in and I can rebase this. What were the options used for pyupgrade so that I can run this myself? |
Collaborator
Author
Sounds good!
It's just with some caveats:
|
728ed9b to
77f4521
Compare
77f4521 to
e5e299a
Compare
Collaborator
Author
|
@inducer Rebased this on |
isuruf
approved these changes
Mar 28, 2022
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed in #98 that there were still places that weren't using new-style
super(), so ranpyupgradeover everything (again?).The commits are nicer to look at separately.