Minor changes to zlibcontext package for node 0.6.0#1
Merged
Conversation
It looks to have changed in node 0.6.
Need a new release of zlibcontext to npm. For better or worse, this is effectively a node 0.6.0 library now.
Author
|
For more background on the need, see the express-spdy bug: eee-c/express-spdy#2 |
Owner
|
thanks |
indutny
added a commit
that referenced
this pull request
Nov 6, 2011
Minor changes to zlibcontext package for node 0.6.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The build location for c/c++ extensions seems to have changed in node 0.6.0. Instead of
build/default, it is nowbuild/Release.I also bumped the version number and node dependency in the hopes that this could be pushed to npm soon :)