Skip to content

chore(deps): Update RestSharp to 113.1.0 and use Timeout property#719

Merged
bednar merged 5 commits intoinfluxdata:masterfrom
drocx:bugfix/removed_deprecated_maxtimeout
Mar 12, 2026
Merged

chore(deps): Update RestSharp to 113.1.0 and use Timeout property#719
bednar merged 5 commits intoinfluxdata:masterfrom
drocx:bugfix/removed_deprecated_maxtimeout

Conversation

@drocx
Copy link
Copy Markdown
Contributor

@drocx drocx commented Feb 12, 2026

Upgraded RestSharp from 112.1.0 to 113.1.0. Replaced all usage of RestClientOptions.MaxTimeout with RestClientOptions.Timeout in code and tests to match the updated API. No other functional changes were made.

MaxTimeout was previously obsolete and was removed in version 113.0.0.

Upgraded RestSharp from 112.1.0 to 113.1.0. Replaced all usage of RestClientOptions.MaxTimeout with RestClientOptions.Timeout in code and tests to match the updated API. No other functional changes were made.
Refactor unit tests in InfluxDbClientFactoryTest.cs to compare RestClientOptions.Timeout using TotalMilliseconds. This aligns the tests with the change of Timeout from an integer (milliseconds) to a (nullable) TimeSpan.
@drocx drocx changed the title Update RestSharp to 113.1.0 and use Timeout property chore(deps): Update RestSharp to 113.1.0 and use Timeout property Feb 12, 2026
Copy link
Copy Markdown
Contributor

@bednar bednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR 👍.

Please fix the CI checks.

@NguyenHoangSon96
Copy link
Copy Markdown
Contributor

Hi @drocx
Can you try to rebase this branch onto main? I'm sure the error in "ci/circleci: dotnet-5.0" will disappear 😺 .

@drocx drocx changed the title chore(deps): Update RestSharp to 113.1.0 and use Timeout property chore(deps): Update RestSharp to 114.0.0 and use Timeout property Mar 11, 2026
@drocx
Copy link
Copy Markdown
Contributor Author

drocx commented Mar 11, 2026

@NguyenHoangSon96
The error is now gone.
But the next RestSharp Update 114.0.0 will break the RedirectCookie Tests:
restsharp/RestSharp#2360

@drocx drocx changed the title chore(deps): Update RestSharp to 114.0.0 and use Timeout property chore(deps): Update RestSharp to 113.1.0 and use Timeout property Mar 11, 2026
@NguyenHoangSon96 NguyenHoangSon96 requested a review from bednar March 12, 2026 02:46
@bednar bednar merged commit 8a99161 into influxdata:master Mar 12, 2026
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants