Skip to content

Revert several changes to fix Influx CLI build#631

Merged
jeffreyssmith2nd merged 3 commits into
masterfrom
smith/revert-task-changes-v2
Mar 6, 2023
Merged

Revert several changes to fix Influx CLI build#631
jeffreyssmith2nd merged 3 commits into
masterfrom
smith/revert-task-changes-v2

Conversation

@jeffreyssmith2nd

@jeffreyssmith2nd jeffreyssmith2nd commented Feb 2, 2023

Copy link
Copy Markdown
Contributor

This PR is meant to serve as a discussion point to see how we might be able to fix the influx cli build. As it stands, the generator tooling used in influx cli cannot handle the current master branch. I believe it has something to do with the new ref style that was added. $ref: ./TaskProperties.yml#/status

I spent about half a day experimenting with different ways to achieve the same idea and couldn't get anything to work, so I wanted to reach out and see if there are any other ideas/suggestions.

With these 2 commits reverted, I can get a working build in Influx CLI

@jeffreyssmith2nd

Copy link
Copy Markdown
Contributor Author

You can see here as far as I got in attempting to refactor, but did not have any luck getting it to build.

@jeffreyssmith2nd jeffreyssmith2nd changed the title Revert several changes to fix Influx CLI build **for discussion** Revert several changes to fix Influx CLI build Mar 3, 2023
@jeffreyssmith2nd jeffreyssmith2nd marked this pull request as ready for review March 3, 2023 19:26
@jeffreyssmith2nd jeffreyssmith2nd requested a review from a team as a code owner March 3, 2023 19:26
@jeffreyssmith2nd jeffreyssmith2nd requested review from sanderson and removed request for a team March 3, 2023 19:26

@sanderson sanderson left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeffreyssmith2nd jeffreyssmith2nd merged commit 5797d11 into master Mar 6, 2023
@jeffreyssmith2nd jeffreyssmith2nd deleted the smith/revert-task-changes-v2 branch March 6, 2023 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants