fix: invalid config for vsphere#7087
Conversation
|
I would regenerate all of them. You can do that in a separate pr if you like. I will approve this pr since it is only touching statically served files and I assume it imported them as they are in the telegraf repo. |
philjb
left a comment
There was a problem hiding this comment.
LGTM -- statically served files; i skimmed them and the changes look ok; but i did not diff them with the source files in the telegraf repo. @NguyenHoangSon96 -- to confirm the import script is working, you could diff the conf and md file with the source ones in telegraf's repo.
|
I may be missing some context here. Based on the original issue, do we need changes other than just removing the dash? This looks like more changes than that. @NguyenHoangSon96 Please also update the PR to merge into master (not influxdata:master), then amend and re-push to rerun the CI pipeline. Before enabling merge I would also address @philjb's comment here. |
Yes and no -- we could just remove the dash but the dash is there because these configs are programmatically generated from the telegraf repo and at the time this conf was generated, the dash was in the telegraf config (incorrectly). The other changes in this pr bring this telegraf plugin conf up to date with the latest conf in the telegraf repo. It's been a long time since these were sync'd. Gunnar used to do them. |
Closes 26912
go run ./cmd/telegraf config > etc/telegraf.confcommand to generateetc/telegraf.conffile.src/writeData/utils/updateTelegrafPlugins.mjsso it will get contents from my localinfluxdata/telegra/etc/telegraf.confinstead of the remote repository/influxdata/telegraf.telegraf-plugins:updatecommand to generate new contents formdandconffiles.This is just a very primitive implementation of the updateTelegrafPlugins.mjs to make the script work
updateTelegrafPlugins.txt
-at the beginning of the.conffile.src/writeData/utils/README.mdguidance and thesrc/writeData/utils/updateTelegrafPlugins.mjsscript file to get contents frometc/telegraf.confin the local repository, not the remote.-at the beginning of the file.Screen.Recording.2025-10-22.at.09.55.53.mov
src/writeData/utils/updateTelegrafPlugins.mjsand run the commandtelegraf-plugins:update, the-at the beginning of the file disappears.Screen.Recording.2025-10-22.at.10.01.23.mov
Checklist
Authors and Reviewer(s), please verify the following: