Skip to content

refactor: improve tracing span usage#22

Merged
prestwich merged 6 commits intomainfrom
prestwich/spannnnn
Feb 20, 2025
Merged

refactor: improve tracing span usage#22
prestwich merged 6 commits intomainfrom
prestwich/spannnnn

Conversation

@prestwich
Copy link
Member

Makes a few span usage changes

  • adds verbose event for param parsing failures in Level::TRACE
  • adds root spans for request and batch request handling in router
  • removes permanently-open spans for tasks
  • moves future instantiation after permit acquisition to delay resource allocation
  • adds span to BatchFuture so that all RouteFutures are inside the batch future
  • add spans that record the params before decoding, and before deserialization

@prestwich prestwich self-assigned this Feb 20, 2025
@prestwich prestwich requested a review from Evalir February 20, 2025 19:13
Copy link
Member

@Evalir Evalir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no nits

@prestwich prestwich enabled auto-merge (rebase) February 20, 2025 21:56
@prestwich prestwich merged commit c43875d into main Feb 20, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants