feat: add Web Clipper intake protocol (openknowledge://clip) and clip-intake schema (#1174) - #1177
Open
Adityakk9031 wants to merge 1 commit into
Open
feat: add Web Clipper intake protocol (openknowledge://clip) and clip-intake schema (#1174)#1177Adityakk9031 wants to merge 1 commit into
Adityakk9031 wants to merge 1 commit into
Conversation
Adityakk9031
requested a deployment
to
inkeep-oss-sync
August 12, 2026 13:56 — with
GitHub Actions
Waiting
|
Thanks for the contribution! What happens next:
|
Contributor
Author
|
@tim-inkeep and @anubra266 have a look |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1174
Description
This PR introduces the secure Web Clipper Desktop Intake Protocol (
openknowledge://clip) andopenknowledge.clip/v1envelope schema as proposed in #1174.What Changed
packages/core):ClipPayloadSchemaandOkClipPayloadinpackages/core/src/schemas/api/clip-intake.tsvalidatingopenknowledge.clip/v1Markdown envelopes.ClipPayloadSchemain core API schemas.packages/desktop):parseClipUrlinpackages/desktop/src/main/url-scheme.tsto parse and validateopenknowledge://clip?destination=<id>&clipboard=truedeep links with path traversal and null-byte defenses.packages/desktop/src/main/clip-intake.tsproviding filename sanitization and "Keep both" collision resolution (article.md->article-1.md).packages/desktop/src/main/url-scheme-clip.test.ts(9/9 tests passing)..changeset/add-web-clipper-intake-protocol.md.Testing
npx vitest run src/main/url-scheme-clip.test.ts(all 9 unit tests passed).parseClipUrlrejects null-bytes, missing destinations, invalid hosts, and path traversal attempts.