PLT-9070 - Marconi components; further generalisation of index running machinery#285
Merged
willjgould merged 28 commits intomainfrom Jan 11, 2024
Merged
PLT-9070 - Marconi components; further generalisation of index running machinery#285willjgould merged 28 commits intomainfrom
willjgould merged 28 commits intomainfrom
Conversation
willjgould
changed the title
berewt
reviewed
Jan 10, 2024
| , mtl | ||
| , nonempty-containers | ||
| , optparse-applicative | ||
| , optparse-applicative-fork |
Contributor
There was a problem hiding this comment.
I don't find this package anywhere, where does it come from and why is it needed?
Collaborator
Author
There was a problem hiding this comment.
It's used by cardano-node: https://github.com/CardanoSolutions/cardano-node/blob/release/8.1.2/cardano-node/cardano-node.cabal#L178C50-L178C50
I've added it here to allow me to combine the CLI args parsers from marconi and cardano-node in marconi-sidechain-node.
It lives here: https://github.com/input-output-hk/optparse-applicative
Contributor
There was a problem hiding this comment.
Hmm... I hate the idea of changing the library because another one is used downstream but I guess we don't have the choice here.
berewt
approved these changes
Jan 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've made
runEmitterAndConsumerandstreamEmittermore general so I can use them inmarconi-sidechain-node.Pre-submit checklist: