remove Utils, clean up Types#298
Merged
berewt merged 2 commits intonicolas/smaller-utilfrom Jan 25, 2024
Merged
Conversation
Author
|
@berewt I requested a review out of habit, but since it targets your branch feel free to merge this at will --- unless you want me to make some changes before merging. |
berewt
added a commit
that referenced
this pull request
Jan 25, 2024
* Less things in the Types module * remove Utils, clean up Types (#298) --------- Co-authored-by: Brendan Brown <brendan.brown@iohk.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This rebases the source branch onto the one for #297, then does some more things.
Marconi.Cardano.Core.Types, e.g. putting some stuff incardano-api-extended.MarconiTraceto theLoggermodule.Utilsmodule entirely, placing things elsewhere when necessary.Marconi.Cardano.ChainIndex.SecurityParammodule for utilities reading theSecurityParamfrom a running node inmarconi-cardano-chain-index.and some other small things.
Noting this targets the branch for #297, and not
main, as discussed.Pre-submit checklist: