Skip to content

remove Utils, clean up Types#298

Merged
berewt merged 2 commits intonicolas/smaller-utilfrom
PLT-8776-cleanup-utils-and-types-modules
Jan 25, 2024
Merged

remove Utils, clean up Types#298
berewt merged 2 commits intonicolas/smaller-utilfrom
PLT-8776-cleanup-utils-and-types-modules

Conversation

@brendanrbrown
Copy link

@brendanrbrown brendanrbrown commented Jan 23, 2024

This rebases the source branch onto the one for #297, then does some more things.

  • Removes more things from Marconi.Cardano.Core.Types, e.g. putting some stuff in cardano-api-extended.
  • Move MarconiTrace to the Logger module.
  • Removes the Utils module entirely, placing things elsewhere when necessary.
  • Creates a Marconi.Cardano.ChainIndex.SecurityParam module for utilities reading the SecurityParam from a running node in marconi-cardano-chain-index.

and some other small things.

Noting this targets the branch for #297, and not main, as discussed.

Pre-submit checklist:

  • Branch
    • Tests are provided (if possible)
    • Commit sequence broadly makes sense and have useful messages
    • Important changes are reflected in changelog.d of the affected packages
    • Relevant tickets are mentioned in commit messages
  • PR
    • (For external contributions) Corresponding issue exists and is linked in the description
    • Targeting main unless this is a cherry-pick backport
    • Self-reviewed the diff
    • Useful pull request description
    • If relevant, reference the ADR in the PR and reference the PR in the ADR
    • Reviewer requested

@brendanrbrown brendanrbrown requested a review from berewt January 23, 2024 20:16
@brendanrbrown brendanrbrown changed the title remove Utils; cleanup types remove Utils, cleanup Types Jan 23, 2024
@brendanrbrown brendanrbrown changed the title remove Utils, cleanup Types remove Utils, clean up Types Jan 23, 2024
@brendanrbrown
Copy link
Author

brendanrbrown commented Jan 23, 2024

@berewt I requested a review out of habit, but since it targets your branch feel free to merge this at will --- unless you want me to make some changes before merging.

Copy link
Contributor

@berewt berewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@berewt berewt merged commit 4f65d0e into nicolas/smaller-util Jan 25, 2024
@berewt berewt deleted the PLT-8776-cleanup-utils-and-types-modules branch January 25, 2024 08:06
berewt added a commit that referenced this pull request Jan 25, 2024
* Less things in the Types module
* remove Utils, clean up Types (#298)
---------

Co-authored-by: Brendan Brown <brendan.brown@iohk.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants