Draft
Conversation
sfeitosa
force-pushed
the
chore-testing-interface-five-contracts
branch
from
5650e4a to
3693458
Compare
sfeitosa
changed the base branch from
chore-testing-interface-pingpong
to
feat/threat-model
bogdan-manole
commented
Mar 10, 2026
Collaborator
Author
bogdan-manole
left a comment
bogdan-manole
left a comment
There was a problem hiding this comment.
Congrats, it looks very well organized.
only two remarks:
- there is a lot of standard output leftover on the auction test suite. In regards of the testing interface you can use the verbose flag in order to choose when those logs to be shown or not
- also it seems for the Vesting the testing interface takes a while for positive and negative testing to be run. I didn't investigate if the actually perform takes so long, or the Arbitrary is struggle to choose proper actions
And i guess the threat model testing is still to be added
- Remove all original sc-tools library sources (base, blockfrost, coin-selection, devnet, maestro, mockchain, node-client, optics, tx-mod, wallet, un-ada) - Remove docs/, node-config/, and shell scripts - Point sc-tools dependencies to chore/only-sc-tools-changes branch via source-repository-package in cabal.project - Update nix config: comment out -Werror for removed packages, rename shell - Retain only convex-testing-interface as a local package
- Update source-repository-package tag reference - Remove pinned sha256 hash
sfeitosa
force-pushed
the
chore-testing-interface-five-contracts
branch
from
c6ed0b5 to
46136fe
Compare
sfeitosa
changed the base branch from
feat/threat-model
to
chore/remove-sc-tools-projects
Base automatically changed from
chore/remove-sc-tools-projects
to
feat/threat-model
March 19, 2026 11:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.