Add support for packages IP ranges in github_ip_ranges#1958
Merged
kfcampbell merged 7 commits intointegrations:mainfrom Feb 2, 2024
Merged
Add support for packages IP ranges in github_ip_ranges#1958kfcampbell merged 7 commits intointegrations:mainfrom
kfcampbell merged 7 commits intointegrations:mainfrom
Conversation
Contributor
|
We're waiting here on the next release of google/go-github. Thanks for the contribution! |
1 task
Contributor
Author
|
@kfcampbell could you please review, i think we are ready to merge it |
Contributor
|
Would you mind adding appropriate checks for these fields in github/data_source_github_ip_ranges_test.go? |
Contributor
Author
|
Test updated! |
kfcampbell
approved these changes
Feb 2, 2024
Contributor
kfcampbell
left a comment
kfcampbell
left a comment
There was a problem hiding this comment.
@Nmishin Awesome, thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1812
Can be merged after go-github change: google/go-github#2964
Before the change?
After the change?
Pull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!