Conversation
More lines-of-code for the same task, but the image generators are much more clear now. This code has become a hassle to work with, and now it's simple again :)
Full matrix of feature tests for py-spy & PyPerf across all desired versions. This is what I suggested in #287 and finally got around to implement. I rather have these in place before performing any other changes on PyPerf/py-spy.
This was referenced Sep 18, 2022
Jongy
commented
Sep 21, 2022
Jongy
commented
Sep 22, 2022
| assert profile.app_metadata is not None | ||
| assert os.path.basename(profile.app_metadata["execfn"]) == app | ||
| # searching for "python_version.", because ours is without the patchlevel. | ||
| assert profile.app_metadata["python_version"].startswith(f"Python {python_version}.") |
Contributor
Author
There was a problem hiding this comment.
This tests #472 (becase we get the Python version from uwsgis as well here)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds full tests for the Python versions matrix: (python version, libc, profiler type).
Based on #477
Add:
uwsgi --pyrun) gets metadata okay (inclpython_version)sys_maxunicodetest