This repository was archived by the owner on May 9, 2024. It is now read-only.
Conversation
Contributor
|
Any specific tests for sh mem or existing set is enough?
Is it worth to be handled as a separate issue? |
Contributor
Author
|
Yes, we'll have some smem specific tests. Address space casts will be addressed separately. |
added 6 commits
June 21, 2023 09:09
Contributor
Author
|
The pass rate is now decent, so this is ready for review. |
alexbaden
approved these changes
Jun 27, 2023
| %no_skip = icmp ne i64 %val, %skip_val | ||
| br i1 %no_skip, label %.noskip, label %.skip | ||
| .noskip: | ||
| %old = call i64 @agg_count(i64* %agg, i64 %val) |
Contributor
There was a problem hiding this comment.
What happens if shared_mem is turned off? What function implementation do we fall back to?
Contributor
Author
There was a problem hiding this comment.
Just noticed the comment. I haven't tested it, but what should happen is it should emit the agg_count from the "cpu" runtime module instead. BTW, I'm not sure if we need the option to disable shared memory at all :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR adds proper code generation for Intel GPUs.
Notes:
genx.llmodule and its size is not checked for now.emitCallwould use the wrong runtime module. This is now fixed by patching the module triple upon extension module load.