Skip to content
This repository was archived by the owner on Mar 14, 2020. It is now read-only.

[Project] Fix wrong sandbox url when clone project#108

Closed
DonnaWuDongxia wants to merge 2 commits into
intel:masterfrom
DonnaWuDongxia:fix-clone
Closed

[Project] Fix wrong sandbox url when clone project#108
DonnaWuDongxia wants to merge 2 commits into
intel:masterfrom
DonnaWuDongxia:fix-clone

Conversation

@DonnaWuDongxia

Copy link
Copy Markdown
Contributor

No description provided.

@DonnaWuDongxia

Copy link
Copy Markdown
Contributor Author

Updated according to John's comments

When clone a project, the whole directory will be cloned for the
new project, so the relative sandbox URL will still point to staff in
orignal project's directory, so we need to change these URL to the new
project's own resources.
Comment thread src/js/projects.js

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We really need a function to change a node's property which is of "url-loadable" type. The prototype of this function may looks like:
ADMNode.replaceURL(searchString, replacement)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants