[Widgets] Add more attributes to some widgets#123
Conversation
There was a problem hiding this comment.
Can we extend it from BCommonProperties.theme?
|
Updated. Please check. |
There was a problem hiding this comment.
Default value should be false rather than "false"
|
Since the follow-on patches are mostly fixes to the initial patch, they should all be merged into one patch. That would make it easier to review as well. Multiple patches in a pull request should be split up based on different functionality that they add, but fixups should be merged in. Here the changes are all loosely related so it's okay for it to be one big patch, but it would also be easier to swallow if some parts were in their own patches (e.g. "new button properties" or "add nativecontrol property to several widgets"). (If those were independent I'd have already merged them.) Note: "git add -p" is an awesome feature for splitting up a patch into multiple ones when you've made too many changes together, FWIW. But not required here. |
|
replaced by PR#139 |
3 participants
No description provided.