This repository was archived by the owner on Mar 14, 2020. It is now read-only.
[Widgets] Add a new "Custom Header" widget#151
Closed
wuyongfeng wants to merge 1 commit into
Closed
Conversation
Closed
Author
|
Modify a bug Geoff said: Try dropping two buttons into the header, then put a Text widget between them, and change it to type 'h2' so they appear on three separate lines. Then drag a vertical button group into the header; try putting one in different places. Some of the widgets appear to be duplicated, I think because they're getting added to all divs, not just one." The root cause is that the locator was "div", which will also match child nodes that have "div". We need to use "> div" to locate the immediate descendant. |
Closed
Contributor
|
Merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So this widget is to add a new "Custom Header" widget that would simply be a div.
Essentially it will then just act the same way the footer does.