[Widgets] Implemented Div widget. #188
Conversation
|
"Limitions" should be "Limitations" "The div only allow" should be "Div is only allowed" |
There was a problem hiding this comment.
"jqm_footer_title" should be changed to "jqm_div_title"
|
Code updated, please review. |
|
The code updated, the widget moved to 'Content Formatting' group, please review. |
|
The palette icon should be in the style of "Form", not the style of "Footer". Please redo that. Div should be categorized under "Simple HTML", not jQuery Mobile for widget set. Other than that, it seems to work well, so we can merge that soon. Thanks. |
|
Could you explain why it's only allowed in Content? Did you run into problems allowing Div inside Div, or other widgets like Grid, Collapsible, etc.? |
|
I guess I see some weirdness if I drop a Button Group into a Div as the first element. The header bars appear right adjacent to each other vertically. On the other hand, if we put a Grid inside of a Grid or something, there is a little margin which makes it easier to use. We should probably have a few pixels of margin like that. Also, this made me notice that when you hover over a ButtonGroup inside a Div, both the Div and ButtonGroup header bars are highlighted (turn gray). The same is true for a Grid inside a Grid, etc; I just never noticed. Probably it would be better to ensure that only the innermost container is highlighted. That is another bug/feature I'll plan to file at some point. |
Nesting of containable widgets still have some drag and drop issues, we had submitted two patches for solve Collapsible nesting issue, but they are workaround so far. John is investigating the issue and seems close to solve it, after the issue solved, I will upload a new patch for the widget. The code will update for your other comments soon, thanks a lot for your reply. |
|
@zhizhangchen The code updated with the comment by @grgustaf the drag and drop in nesting widgets issue seems not happen in the Div widget, please review. |
|
@grgustaf Div should be categorized under "Simple HTML", not jQuery Mobile for widget set. |
Limitations: 1. Div is only allowed in Content. 2. Nesting of Div is not allowed.
|
@zhizhangchen My mistake, the code updated, please review. Thank you for your reminder. :-) |
|
You didn't remove "Div" from content formatting group |
|
@zhizhangchen "Functional groups" and "Widget sets" are different group, maybe Div needs exist in these groups, could you confirm it's need to remove Div from content formatting ? |
|
Merged. |
|
Oops, I lost my other comment: This is a really great feature, and a nice clean patch. Thank you! |
3 participants
Limitions: