This repository was archived by the owner on Mar 14, 2020. It is now read-only.
[Widget] Fixed List Filter is not part of List.#198
Closed
xuqingkuang wants to merge 1 commit into
Closed
Conversation
Contributor
|
This causes a rendering problem in the design canvas if you also turn off the Inset flag. Please look into handling that case as well. But it definitely works great otherwise, thanks. Should be able to get this in w/ that fix. |
Contributor
Author
|
@grgustaf @zhizhangchen The code updated, fixed render issue after checked Inset flag. Please review. |
Closed
Contributor
|
I'll go ahead and merge this, but really we should fix it so that the "inset" change is visible in the design canvas, as it used to be. Otherwise it's hard for the user to know what inset is really changing. |
Contributor
Author
|
@grgustaf Could you provide more information ? I checked the doc - http://jquerymobile.com/test/docs/lists/docs-lists.html inset attribute seems only applied the round conner for list. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.