This repository was archived by the owner on Mar 14, 2020. It is now read-only.
[FixBug] Pages navigation arrows show slowly#212
Closed
zeroooing wants to merge 2 commits into
Closed
Conversation
Contributor
|
Very good patch! Please revise the commit message a little to something like: |
Contributor
Author
|
Commit message revised |
Contributor
There was a problem hiding this comment.
Should we also use
Contributor
Author
There was a problem hiding this comment.
No need a second filter . The jQuery function outerWidth() will "Get the current computed width for the first element in the set of matched elements". And all the pageIcons have the same width.
Contributor
There was a problem hiding this comment.
Yes. But to be safe, please use the second filter. There's possibility that the scroller doesn't have a child in other page view.
Closed
Contributor
|
Great improvements, thank you very much. Merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.