This repository was archived by the owner on Mar 14, 2020. It is now read-only.
[Another] Fix bug quickly delete and bug that can not paste cutted page#220
Closed
DonnaWuDongxia wants to merge 2 commits into
Closed
[Another] Fix bug quickly delete and bug that can not paste cutted page#220DonnaWuDongxia wants to merge 2 commits into
DonnaWuDongxia wants to merge 2 commits into
Conversation
Contributor
Author
|
with #217, I found a bug of layout view. You can select a "radio button" in layout view, and then change tab to other views, such as go to preview, and then change back to layout view, you will find that the selected radio button lost the green box. |
Contributor
Author
|
Originally, the node was removed first and then set one of its siblings as selected, the "nodeRemove" event is fired first, "select event" later. But in #217, I made the select event go first, so some widget will lose the green box in layout view. |
Contributor
|
Why do you do this in fireModelEvent instead of in removeChildFromZone? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.