[Properties] Highlight change#226
Conversation
|
Please rebase it with upstream/master as there's some conflict |
|
rebased |
There was a problem hiding this comment.
Missing "}" of if block
|
Hmm, I'm not sure what to think about this one. I've never seen an app do this before. Is there precedent? It's kind of cool. :) But it's not completely consistent. It doesn't work on checkboxes, and it doesn't work on Select Option fields. I haven't tried to exhaustively test or anything. I'll have local QA folks look at it for another opinion. |
|
I happened to test this on a page with a Grid with 5 columns and 10 rows. Everything slows down to a crawl. And sometimes the yellow fade animation appeared at the wrong time. I change the page's id field, and tab off. Earlier it stayed white but then later might turn yellow and fade. Now what I see is it immediately turns yellow, stuck there for a second or two, and then finally starts animating. It looks like this is maybe just a general performance problem that I should look into, but I'm hesitant to take the patch after seeing that. |
|
@grgustaf I tried to place a Grid with 5 columns and 10 rows, the latest master tree already slow down when changed property. Investigating the issue with Web inspector timeline you will see the most of times is spending on the line 155 of adm.js - "setTimeout("ADMEventQueue.processEvents()", 0);". With max's patch the time is 6.46s, without is 6.10s. |
|
Suggestion: how about move the UI effect codes to input/select event binding directly? Effects will be async and not affect the main thread. |
|
The main issue is that the time is longer than 6s. @grgustafhttps://github.com/grgustaf I tried to place a Grid with 5 columns and 10 rows, the latest master tree already slow down when changed property. Investigating the issue with Web inspector timeline you will see the most of times is spending on the line 155 of adm.js - "setTimeout("ADMEventQueue.processEvents()", 0);". With max's patch the time is 6.46s, without is 6.10s. |
|
Updated to support Checkboxes. Hmm, I'm not sure what to think about this one. I've never seen an app do this before. Is there precedent? It's kind of cool. :) But it's not completely consistent. It doesn't work on checkboxes, and it doesn't work on Select Option fields. I haven't tried to exhaustively test or anything. I'll have local QA folks look at it for another opinion. |
* adjust the spaces between the first line and title * cancel limit of height for li element in ribDialog * clean up used style
…ette Also, fix a glitch in selection handling during a moveNode that resulted from the selection changing once on the node's removal and again on the node's reinsertion. At the same time, fix a violation of the ADM/ADMNode abstraction barrier so that ADMNode is not directly managing the selection in the ADM. Finally, add a clearEvent call for selectionChanged to throw out any obsolete events in the queue.
* extend to get value of options by function
* provide a default option for imported theme file
Output message in dumplog will not be printed out if DEBUG if false.
This is intented to fix bug that if you click the blank space below footer in layout iframe, the delete button in property view and delete key will not work.
…ing tab Description: selected check-box, toggle-switch or radio button in layout view will lose green selection box after changing tab to other views, for instance code view or preview.
Vertical ButtonGroup appears as haux-horizontal in Footer
This patch indirectly fixes the problem, but there appears to still be a bug related to the lazy autogeneration of id properties. They should be assigned in a deterministic order.
For force generate ID property for event handler.
Completed: 1. Event handler dialog construct 2. JS code exporting. 3. JS Preview.
Also, gray out the property label when it's disabled by prereqs. And move the more important options property of the select menu above everything else.
* modify parser function to support minified theme * refactor uploadTheme function: add a handler to update items in project dialog when upload finished
* add a new property allThemes to record all themes * refactor uploadTheme function
* also clean up some spaces in deflate.js file
* Every design has a unique theme css. If we make theme css value as a special mark, it is very easy to update theme for design.
* We can use this API to update the theme for a given design. It will be used to change the theme of the current project and preview for adding a new page.
* setDesignTheme() will be used to change theme
*When theme of current project changes, it will trigger property Change event. Original there is no response for design node. In order to make selected widget display changed themes, we refresh property view when changed property is css.
* if theme of current design changes, we should inform design to update
Also, move some debug output from alert to console.
|
Submitted PR#269 instead. |
7 participants
No description provided.