Skip to content
This repository was archived by the owner on Mar 14, 2020. It is now read-only.

[Property View] Fix two bugs of property view#232

Closed
zeroooing wants to merge 2 commits into
intel:masterfrom
zeroooing:Grid
Closed

[Property View] Fix two bugs of property view#232
zeroooing wants to merge 2 commits into
intel:masterfrom
zeroooing:Grid

Conversation

@zeroooing

Copy link
Copy Markdown
Contributor

No description provided.

Comment thread src/js/views/property.js Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is "continueToDeletei" a typo?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@grgustaf

Copy link
Copy Markdown
Contributor

This patch allows me to enter "6" for columns which breaks the Grid layout and you can no longer change Columns at all. Values above 5 should be clamped to 5. Similarly values less than 2 should not be allowed. Similarly, Rows should be clamped to 1-100 range.

Finally, there is some weird focus behavior. You cannot click always click repeatedly on the spin control buttons up or down. Sometimes the text gets highlighted orange, the gray keyboard focus rectangle appears, and it won't accept further clicks up or down. This doesn't happen all the time, but usually pretty fast if you click up and down a few times. Particularly if you click fast, I guess.

@zeroooing zeroooing closed this Aug 28, 2012
@zeroooing

Copy link
Copy Markdown
Contributor Author

Yes , the weird focus behavior is caused by another bug about focus. And the column has been clamped to 2--5 , as row to 1--100

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants