This repository was archived by the owner on Mar 14, 2020. It is now read-only.
Add theme selector to the new page dialog#235
Closed
xuzhang wants to merge 5 commits into
Closed
Conversation
* extend to get value of options by function
* provide a default option for imported theme file
Contributor
Author
|
When theme changes, all node should adjust "theme" property. So It is better using themeEvent to handle. |
* add a new ADM event themeChanged, which is used to update theme property of all nodes * when theme changes in project setting, it will trigger themeChanged event * add a _themeChangedHandler in base.js to handle update of all view
Closed
Contributor
|
Actually, I'm going to leave off the patches for the theme selector on the Add Page dialog as well. This is because I don't think it makes sense to pick a swatch when you can't see the effect it's having. We need to have a dynamic preview in the Add Page dialog before that makes sense, and I think that will be a challenging feature to add so it's not something that should happen this week as we're trying to fix bugs and stabilize. I submitted this feature request: |
Contributor
|
Merged first two of five patches. |
Contributor
Author
|
Split this pull request. One is sent with PR#260. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.