Skip to content
This repository was archived by the owner on Mar 14, 2020. It is now read-only.

Horizontal button group#248

Closed
zhizhangchen wants to merge 2 commits into
intel:masterfrom
zhizhangchen:horizontal-button-group
Closed

Horizontal button group#248
zhizhangchen wants to merge 2 commits into
intel:masterfrom
zhizhangchen:horizontal-button-group

Conversation

@zhizhangchen

Copy link
Copy Markdown
Contributor

Separate ButtonGroup into VButtonGroup and HButtonGroup and forbid VButtonGroup to be in Footer as it's rendered as faux-horizontal

Introduced ControlGroup as base widget for ButtonGroup, RadioGroup
and CheckboxGroup, then base horizontal and vertical ButtonGroup
on ButtonGroup
@grgustaf

Copy link
Copy Markdown
Contributor

I think it's nicer to let the user toggle between horizontal and vertical. I guess you must have run into some trouble trying to implement it though?

I like having both in the palette, but the Horizontal one's text looks funny so I would just call that "Button Group" and keep the normal font size. (Make it appear before Vertical Button Group.)

Then we could disallow the Vertical Button Group palette item in the footer. But I'd prefer that they both show up as simply "Button Group" in the outline view. Then the only trick is disabling the orientation property when the widget is in the footer, and automatically converting it if they drop a vertical one in from elsewhere in the design.

That may be too hard to get in this week, but I'd rather wait for that solution then take this patch now.

@zhizhangchen

Copy link
Copy Markdown
Contributor Author

replaced by #256

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants