This repository was archived by the owner on Mar 14, 2020. It is now read-only.
[Property View] Use jQuery UI button to reimplement delete button.#249
Closed
xuqingkuang wants to merge 1 commit into
Closed
[Property View] Use jQuery UI button to reimplement delete button.#249xuqingkuang wants to merge 1 commit into
xuqingkuang wants to merge 1 commit into
Conversation
Closed
Contributor
|
The icon and button should match the one on the home/projects page. The size of the icon part should be the same size, and preferably the button should be the same size as well. For this new one, the icon is smaller and the button is bigger. Also, the border should be the same. This one gains a border on hover, and flashes white on active. The home page one always has a border and flashes dark gray on active. The ones on the home page are according to the design mockups we had, so let's follow that for this one, hopefully reusing the same CSS classes. |
Contributor
Author
|
@grgustaf and @zhizhangchen The code updated for your comments, please review, thanks a lot! |
Closed
Contributor
|
Merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For hover effect.