Fix some issues on theme #253
Conversation
xuzhang
commented
Aug 27, 2012
xuzhang
commented
- support minified css file
- support zip file
|
rebase again according to suggestions. |
|
There are some bugs. For instance, if I install my irish.zip theme, I see green widgets in layout view and preview, but then if I upload the non-minified CSS version over it, I see green widgets in layout view but regular widgets in preview. Finally, if I reload, I don't see green widgets in either place. Then if I switch theme to default, and back again, I see green widgets in both places again. At least once I saw green widgets in preview but not in layout view; I'm not sure exactly how I did that. I'm tempted to still merge this, since it's very nice to have zip support, but I'd prefer to have this fixed. Maybe if I get through the other pull requests I'll merge this later in the day. |
|
I have noticed this issue and sent another pull request for this issue. If you don't accept it, I will try to merge two pull request to one. |
* modify parser function to support minified theme * refactor uploadTheme function: add a handler to update items in project dialog when upload finished
* add a new property allThemes to record all themes * refactor uploadTheme function
* also clean up some spaces in deflate.js file
* Every desing has a unique theme css. if we make theme css value as a special mark, it is very easy to update theme for design.
* we can use this API to update theme for given design. It will be used as changing theme of current project and previewing for adding a new page.
* setDesignTheme() will be used to change theme
*When theme of current project changes, it will trigger property Change event. Original there is no response for design node. In order to make selected widget display changed themes, we refresh property view when changed property is css.
* if theme of current design changes, we should inform design to update
|
fixed bug and rebase the code. |
|
Merged, thanks! |
2 participants
