Skip to content
This repository was archived by the owner on Mar 14, 2020. It is now read-only.

[Tree View] Fix bug: When moving a selected node, outline view loses sel...#257

Closed
zhizhangchen wants to merge 1 commit into
intel:masterfrom
zhizhangchen:outline-view-lost-selection-when-moving-node
Closed

[Tree View] Fix bug: When moving a selected node, outline view loses sel...#257
zhizhangchen wants to merge 1 commit into
intel:masterfrom
zhizhangchen:outline-view-lost-selection-when-moving-node

Conversation

@zhizhangchen

Copy link
Copy Markdown
Contributor

...ection

@grgustaf

Copy link
Copy Markdown
Contributor

The weird thing now is that when you drag a new widget in from the palette, the old one remains highlighted at the same time as the new one, and then the old one gets unhighlighted.

@grgustaf

Copy link
Copy Markdown
Contributor

The best solution for this could be a little tricky. I expect the outline view sees a "node insertion" event followed by a "node selected" event. Perhaps we should included the updated selection as part of the node insertion event?

Or we could just check for the current selection as we handle the node insertion event in the outline view, it's probably already been set, we just haven't seen the selectionChanged event yet.

@zhizhangchen

Copy link
Copy Markdown
Contributor Author

Yes, it's a little tricky. I updated the PR to set selected node while creating tree node to make sure only one node is selected and it also makes it unnecessary to scroll when moving node.

@grgustaf

Copy link
Copy Markdown
Contributor

Merged.

@grgustaf grgustaf closed this Aug 29, 2012
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants