This repository was archived by the owner on Mar 14, 2020. It is now read-only.
[Property View] Fix bug: Grid uses two types of form widget for interger#262
Closed
zeroooing wants to merge 1 commit into
Closed
[Property View] Fix bug: Grid uses two types of form widget for interger#262zeroooing wants to merge 1 commit into
zeroooing wants to merge 1 commit into
Conversation
Closed
Contributor
|
The bounds checking is good and seems to work right. However, you still can't reliably click the up and down arrow buttons. It gets stuck and won't accept them sometimes. It looks to me like strangeness with how we're handling keyboard focus and stuff, we have just too many state changes going on. Donna has some bugs assigned about this keyboard focus stuff. Perhaps in later patches some of this is improved, so I'll check back on this later in the day. |
Contributor
|
Please rebase this PR as there are some conflicts |
Closed
Contributor
|
Replaced by #270 |
Contributor
|
Closed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[Property View] Fix bug: Grid uses two types of form widget for interger