This repository was archived by the owner on Mar 14, 2020. It is now read-only.
[Rebased] Show image options as datalist in property view#265
Closed
DonnaWuDongxia wants to merge 3 commits into
Closed
[Rebased] Show image options as datalist in property view#265DonnaWuDongxia wants to merge 3 commits into
DonnaWuDongxia wants to merge 3 commits into
Conversation
Contributor
|
It seems it still can't be automatically merged. Please try fetching upstream and rebase again |
Contributor
Author
|
updated |
Closed
Contributor
|
The status of the images is not a property of the Design, but rather the Project/Filesystem. If the user chooses NOT to delete an image for instance, after removing the last use in the design... it is no longer in the design, but you'd still want it in the list because it's available. |
Contributor
|
The first patch seemed like a nice cleanup so I took that even though I didn't take the other two patches yet. |
Contributor
Author
|
replaced by #273 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.